- Issue created by @coby.sher
- First commit to issue fork.
- @abhisekmazumdar opened merge request.
- Status changed to Needs review
about 1 year ago 5:24pm 30 September 2023 - 🇮🇳India abhisekmazumdar India
I tried to remove anything that was created by the install hook and needed to be removed. Not everything needed to be deleted, so I only removed:
- DpPreviewSite - example_nextjs_preview
- user - pantheon_decoupled
- role - pantheon_decoupled
- Status changed to Needs work
about 1 year ago 7:49pm 24 October 2023 - 🇺🇸United States brianperry
Open to discussion here, but I worry about deleting things like users and roles (less so preview sites) on uninstall since we don't know if they were repurposed or modified. Proposed some alternatives to consider on the MR that check for existence before creating rather than deleting on uninstall.
- 🇩🇪Germany rvolk Frankfurt
Creating users and roles always opens up a couple of related issues. To do it right, the status page should indicate if something is missing, this way site builders can still extend the user and role model, while the module will only ensure the minimum requirements are met. After uninstall a message to the user might be sufficient, informing him that he can delete the user now. So the optional configuration approach in combination with a status checks should be sufficient for the current case. If we want to remove the user and role, we must make sure that it has not been modified or repurposed.
Once the status check is in place, we can use the same routine in the install process and only create the user if missing.
The preview site feels like a no brainer, should be fine to simply remove it.
- 🇺🇸United States brianperry
> After uninstall a message to the user might be sufficient, informing him that he can delete the user now.
A message that the user and role can be deleted is a nice additional step if we're leaving it behind. Thanks for the suggestion @rvolk