- Issue created by @matthijs
- @matthijs opened merge request.
- Status changed to Needs review
over 1 year ago 8:32am 7 September 2023 - 🇧🇪Belgium matthijs
This MR changes the return of saml_sp_authn_context_class_refs() and adds an alter hook.
- Status changed to Needs work
over 1 year ago 2:32pm 7 September 2023 - 🇺🇸United States jproctor
This is a great improvement but it changes the API for an existing public method.
Can we make it backwards compatible and add a deprecation warning? I don’t see an easy way to do that other than changing the function name (remove
class? spell outauthenticationorreferences?) but you may have another idea. - 🇧🇪Belgium matthijs
I personally don't think changing the functions outcome is a problem since it's not a class method, but if you do I suggest to move my changes to a new function, use that everywhere and adjust the existing function to call the new one and return a value in the same format as before.
WDYT?