Contrib.social

Clarification in dependency of config_filter version

Open on Drupal.org →
Created on 6 September 2023, over 1 year ago
Updated 3 June 2024, 7 months ago

Problem/Motivation

Hello and thank you for your work getting a D10 release of this module out :)

As part of #3296851 it looks like version dependencies were introduced into the composer.json file.

"drupal/config_filter": "^2.4" was introduced - config_filter also has a D10 release of the 1.x branch which would appear compatible with this module. (I am using config_filter v1 with config_profile 1.0 without issue).

I just wanted to check if there was a reason for adding this version requirement?

The motivation here is the config_split v1 depends on config_filter v1, and the v2 branch of config_split only has a release candidate, not a stable release at this point.

Also a dependency was added to drupal/core - please note the advise on https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-fi... →

It is better not to provide a drupal/core version requirement in composer.json because Drupal's composer facade will generate the appropriate metadata based on the info.yml file

Happy to patch if this was not intentional.

Cheers

Steps to reproduce

Try composer require 'drupal/config_profile:^1.1' 'drupal/config_split:^1.9'

Proposed resolution

- Remove core dependency from composer file
- Allow v1 branch of config_filter

Remaining tasks

- Confirm proposed resolution
- Patch
- Review
- Commit
- Release

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇳🇿New Zealand ericgsmith

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024