Drupal 10 Compatibility

Created on 6 September 2023, 10 months ago
Updated 20 October 2023, 9 months ago

Hi, we thank you for the module and it's been working great for our website. Just wanted to check to see if there will be an updated version that is compatible with Drupal 10.

💬 Support request
Status

Closed: duplicate

Version

2.1

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @tkim49
  • 🇮🇳India sarwan

    Hi @tkim49
    I have fixed this issue, Now it is Compatible with Drupal10.

  • Thank you @sarwan. Unfortunately, I'm not able to apply the provided patch since running "composer require 'drupal/adobe_launch:^2.0'" fails (see below message) as my site is already on Drupal 10. Can you please create a new version having this patch included?

    drupal/adobe_launch 2.0.0 requires drupal/core ^8 || ^9 -> found drupal/core[8.0.0, ..., 8.9.20, 9.0.0, ..., 9.5.10] but these were not loaded, likely because it conflicts with another require.

  • 🇮🇳India sarwan

    Hi @tkim49, You need to clone the code of this module through git and then apply the patch.
    Another way to do that is just add the above changes in the info.yml file and clear the cache. Then you can use it in the Drupal 10.

    For this patch to apply the maintainer needs to merge this patch file in the source code of this module. Until then you have to use above two methods.

  • Thanks @sarwan. Unfortunately, our company's policy is not to make any changes directly to the core and contributed modules. Do you know when the maintainer would be able to merge the patch to the source code?

  • 🇮🇳India sarwan

    Hi @tkim49, sorry no idea about that.

  • Status changed to Needs review 9 months ago
  • 🇺🇸United States inversed

    @tkim49, the typical way to deal with this can be found here: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

    Essentially, adding a composer plugin and white-listing the project should let you require it and apply the patch. I've confirmed on my local that this is working (I've used this for other projects).

    In your composer.json file, in the extra property, you would need to add the following:

            "drupal-lenient": {
                "allowed-list": ["drupal/adobe_launch"]
            }
    

    And in the config.allow-plugins property, you would need to add the following:

        "mglaman/composer-drupal-lenient": true
    
  • Status changed to Closed: duplicate 9 months ago
  • 🇺🇸United States ansonwhan

    Noting here this issue is a duplicate of the automated Drupal 10 Compatibility update bot issue at https://www.drupal.org/project/adobe_launch/issues/3285992 📌 Automated Drupal 10 compatibility fixes Fixed . The patch / update has been rolled into release 2.1.0

    No changes in functionality to the module.

Production build 0.69.0 2024