[GitlabCI] SQLite currently not working

fjgarlin → closed merge request !8

Moving this to core. Recommended to create a new fork and branch from there instead.

A good starting point for the new MR is to uncomment the SQLite options in the matrix and start testing/debugging within the MR.

DSN needs fix https://www.php.net/manual/en/ref.pdo-sqlite.connection.php

Somehow run-tests require --dburlin custom format https://git.drupalcode.org/issue/drupal-3385620/-/jobs/97891

ERROR: Invalid --dburl. Reason: Minimum requirement: driver://host/database

I pushed fake sqlite-3 image which is sleeping all the time, so it used to conform other databases

https://git.drupalcode.org/project/drupalci_environments/-/commit/e72735...

Nightwatch tests needs variable https://git.drupalcode.org/issue/drupal-3385620/-/jobs/98006

And one kernel test fails https://git.drupalcode.org/issue/drupal-3385620/-/jobs/98034

    Testing Drupal\Tests\migrate\Kernel\SqlBaseTest
    .F..                                                                4 / 4
    (100%)
    
    Time: 00:03.946, Memory: 4.00 MB
    
    There was 1 failure:
    
    1) Drupal\Tests\migrate\Kernel\SqlBaseTest::testBrokenConnection
    Failed asserting that exception of type
    "Drupal\migrate\Exception\RequirementsException" is thrown.
    
    /builds/issue/drupal-3385620/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
    /builds/issue/drupal-3385620/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
    /builds/issue/drupal-3385620/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
    
    FAILURES!
    Tests: 4, Assertions: 17, Failures: 1.

Wow I didn't even realize this was not yet working — because in my experience, SQLite-on-RAMdisk is way faster than MySQL. So that means this has the potential to further speed up the time to get complete test results. Maybe not for core (where MariaDB/MySQL is used by >90% of sites), but for contrib it could help!

For D7 core, where it just worked without issues on a very similar setup, SQLite is blazing fast.

I'm close to finish some other priorities (like D7 core and D7 contrib GitlabCI integration) and then I should be able to jump on this, but happy for you all to try to fix and debug.

If it's significantly faster than mysql we could consider setting sqlite as the default MR environment, and then ensure we run MySQL tests too prior to commit.

I think this is ready for review now.

MR: https://git.drupalcode.org/project/drupal/-/merge_requests/4820/diffs

Note that we skipped two tests for SQLite based on Slack conversation https://drupal.slack.com/archives/CGKLP028K/p1695980781697999 with @catch. Both tests test for a non-existent database but SQLite creates them on the fly if they don't exist.

Pipeline with SQLite runs: https://git.drupalcode.org/issue/drupal-3385620/-/pipelines/25125

Looks great to me, we're only skipping the tests here no actual refactoring, so I think it's OK in the one issue. We should enable this and then we'll get a better idea about overall stability - and be able to switch more of DrupalCI off too.

Agree that skipping those two tests on SQLite is fine given they are only for edge cases in migrate.

Committed and pushed d0cfc6d004 to 11.x and 7f06eb5ed8 to 10.1.x. Thanks!

Moved sqlite down to daily tests for 11.x and 10.1.x on DrupalCI.

Automatically closed - issue fixed for 2 weeks with no activity.

andypost → closed merge request !4820