- Issue created by @ericgsmith
- last update
over 1 year ago 1 pass - @ericgsmith opened merge request.
- Status changed to Postponed
over 1 year ago 2:11am 6 September 2023 - π³πΏNew Zealand ericgsmith
I have started work on this.
Replacing core/jquery.once with core/once as jquery.once is removed in D10.
Bumped version requirement to 9.2 as this is when core/once was introduced.Testing on 10.1
Test steps
- Enabled module
- Added a test rule
.node-form:[ label]
- Visited node/add/page
- Confirmed all labels were hidden
- Pressed the "Switch to advanced" button
- Confirmed all labels were visible
It was looking good!
But then, after clearing the cache, it all stopped working.
Investigating I found the module is placing CSS into the
public://css
directory.When the cache is rebuilt either by Drush or through the UI via the performance screen -
deleteAll
is called on the CSS Optimizer service https://git.drupalcode.org/project/drupal/-/blob/10.1.1/core/lib/Drupal/...This removes the CSS generated by the module.
While it would be a simple fix to change the dir - this is still a problematic was to generate the CSS which is already resolved in https://www.drupal.org/project/advancedform/issues/3230831 β¨ Support loading rules (and updating CSS) from saved configuration Fixed
I am in favour of pause this, get https://www.drupal.org/project/advancedform/issues/3230831 β¨ Support loading rules (and updating CSS) from saved configuration Fixed committed, then review this.
- Status changed to Needs work
over 1 year ago 4:15am 15 September 2023 - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass -
xurizaemon β
committed 5a293866 on 2.0.x authored by
ericgsmith β
Issue #3385484: Drupal 10 compatibility
-
xurizaemon β
committed 5a293866 on 2.0.x authored by
ericgsmith β
- Status changed to Fixed
over 1 year ago 5:22am 15 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.