Deprecated function: Creation of dynamic property Cleantalk\Common\Firewall\Modules\Sfw::$set_cookies

Hello.
Thank you for your request.
We will look into it and test our Anti-Spam for Drupal 10 within 3 business days.
Please, wait.

Hi, I have fixed deprecated function, please review and verify.

If the above merge doesn't solve the issue then you can code this

private $logTable;
    private $dataTable;
    private $params = [];

    public function __construct($log_table, $data_table, $params = []) {

in place of public function __construct($log_table, $data_table, $params = array())to solve the issue.

Hello and thank you for your effort.
I added your suggestions to the task. Please, wait up to 3 work days.

The patch in #5 breaks the website.

[Sat Sep 16 08:08:38.363144 2023] [proxy_fcgi:error] [pid 1851118:tid 129741197379264] [remote 192.168.0.131:51663] AH01071: Got error 'PHP message: PHP Fatal error: Attribute "AllowDynamicProperties" cannot target method (allowed targets: class) in /var/www/drupal/web/modules/contrib/cleantalk/lib/Cleantalk/Common/Firewall/Modules/Sfw.php on line 58'

Hi @tjharman, please use the code in comment #7 and the original code.

Dear customers

We have added a new feature, now you can send debug logs without having to provide access to your site.

Please install this version and send us the debug logs.

The MR above is not correct because the annotation to suppress the message applies at the class level, not at the function level, and it's being applied to the wrong class. I attach a patch that works for me with PHP 8.2.

Thank you @alfaguru. I will add this patch and all the info to the task. We will check it and will let you know the results.

+1 for #12

Hello,

We have fixed the issues and released a new version 9.3.0:
https://www.drupal.org/project/cleantalk/releases/9.3.0 →

Please, update the module and clear your website cache.

Did it help?

no, not all of them. I was already using 9.3.0 and still had one of these deprecation warnings:

Deprecated function: Creation of dynamic property Cleantalk\Custom\Db\Db::$db_result is deprecated in Cleantalk\Custom\Db\Db->fetchAll() (Zeile 81 in /web/modules/contrib/cleantalk/lib/Cleantalk/Custom/Db/Db.php)

Hello agoradesign,

The warning you specified is different. Please create a separate thread.
Our developers will deal with this issue and within 5 working days we will report the result in your new thread.

The notice `Creation of dynamic property Cleantalk\Common\Firewall\Modules\Sfw::$set_cookies is deprecated` was fixed by getting changes to the common library https://github.com/CleanTalk/_sfw/commit/f4ba5b514c042786156d9152c100a2c... and these changes was loaded into the module code base
The notice `Creation of dynamic property Cleantalk\Custom\Db\Db::$db_result` was fixed by commit https://git.drupalcode.org/project/cleantalk/-/commit/837d2d8ae622f724ac...

glomberg → closed merge request !18

Automatically closed - issue fixed for 2 weeks with no activity.