- Issue created by @timotej-pl
- 🇮🇳India sarwan
i have fixed this issue d10 compatibility and also attached patch.
- Assigned to Nick Hope
- 🇹🇭Thailand Nick Hope
There's more needed here than just the core_version_requirement. I'm fixing some other issues (deprecations, errors, warnings, coding standards).
- Issue was unassigned.
- Status changed to Needs work
6 months ago 7:06pm 7 January 2024 - 🇹🇭Thailand Nick Hope
I've added D10 compatibility (including adding
^10to alpha_pagination_sample_view.info.yml as well as alpha_pagination.info.yml) and fixed numerous deprecations, coding standards etc. across multiple files.However there are a few remaining issues which are beyond my skill level...
Most importantly, "Show More" does not work for me. It does not show more.
Furthermore, after clicking "Show More", then clicking back to a letter, I get this warning:
Warning: Undefined array key 1 in Drupal\Core\Asset\LibraryDependencyResolver->doGetDependencies() (line 67 of core/lib/Drupal/Core/Asset/LibraryDependencyResolver.php).
Google that error for a couple of other modules that have had it.
Those problems may be related to https://www.drupal.org/project/alpha_pagination/issues/3388414 🐛 Exposed form "Reset" button does not reset pagination state Active .
Besides that, PHPStan advises "\Drupal calls should be avoided in classes, use dependency injection instead" 2 remaining times in AlphaPagination.php and 1 in
AlphaPaginationCharacater.php.phpcs advises "t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead" 4 remaining times in AlphaPagination.php. Unfortunately
$this->t()can't be used there directly. This thread might hold a clue: https://drupal.stackexchange.com/questions/257631/call-to-undefined-func....Finally, intelephense doesn't like
function hook_alpha_pagination_alphabet_alter(array &$alphabets, \views_handler_area_alpha_pagination $view)in alpha_pagination.api.php.