Image style flush takes long for many images

There are a couple of solutions, that I could propose:

Solution 1:

Replace image flush with a custom implementation, that will do the flush in a batch or a cron queue, so that the deployment process does not take too long.

Solution 2:

Override the way how the image styles flush works in Drupal core (\Drupal\image\Entity\ImageStyle::flush).
Instead of recursively deleting every file, we could execute rmdir and delete s3fs_file records with a LIKE condition: DELETE * FROM s3fs_file WHERE uri = "public://styles/{imagestyle_name}%"

Comments & Activities

Issue created by @a.milkovsky
Comment 10 months ago →
🇺🇸United States cmlara
We shouldn't touch the ImageStyle entity, it is massive and a complex mess until ✨ Split ImageStyle into the config entity and a separate event-based image processing service Needs work gets into core.

We should also avoid coupling too closely to core, we are an I/O layer, the less coupling the better.

Our best solution would be to modify S3FileService::deleteRecursive() to obtain a directory list and delete in batches so that there are not as many API requests. This would improve recursive deletes across the entire ecosystem instead of just for ImageStyle flushes.

We could probably use \Aws\S3\BatchDelete to save us from writing a large portion of the code and to only need to provide an iterator of files.

Moving to a feature request and assigning to 4.x for initial implementation.
Comment about 1 month ago →
🇫🇮Finland ZeiP
Core issue ✨ Add possibility to skip flushing all image style derivatives when an image style configuration changes Needs work is also about this.

Image style flush takes long for many images

Background:

There are a couple of solutions, that I could propose:

Solution 1:

Solution 2:

Comments & Activities