Contrib.social

Empty 'show for roles' should mean show for everyone

Open on Drupal.org →
Created on 4 September 2023, over 1 year ago
Updated 26 January 2024, 11 months ago

Problem/Motivation

When adding a menu item I always need to select allowed roles for every menu item. I've got used to that in similar Drupal functionalities empty 'allowed' list always means allowed for everyone.

Steps to reproduce

Just create a menu item with 'Roles able to see the menu link' being empty. The item won't show to anyone.

Proposed resolution

When both menu_per_role__show_role and menu_per_role__hide_role fields are empty, show the item for everyone.

I've attached a small patch for it.

✨ Feature request
Status

Closed: cannot reproduce

Version

1.0

Component

User interface

Created by

🇺🇦Ukraine dlevchik

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @dlevchik
  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    4 pass
  • Comment over 1 year ago →
    🇫🇷France Grimreaper France 🇫🇷
  • Status changed to Postponed: needs info over 1 year ago
  • Comment over 1 year ago →
    🇫🇷France Grimreaper France 🇫🇷

    Hi,

    I tried to reproduce the problem, but currently when there is no role selected for either showing or hiding the menu link, the menu link is displayed.

    Please provide an automated test that shows the problem.

  • Status changed to Closed: cannot reproduce 11 months ago
  • Comment 11 months ago →
    🇫🇷France Grimreaper France 🇫🇷

    Hi,

    Closing as there was no replies in 5 months.

    Re-open when able to provide detailed steps to reproduce or a failing test.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024