- Issue created by @Ryo Yamashita
- last update
over 1 year ago 367 pass - @ryo-yamashita opened merge request.
- πΊπΈUnited States yas California πΊπΈ
@ryo-ymashita
Please check the coding standards:
FILE: .../html/web/modules/contrib/cloud/src/Controller/ApiController.php ---------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES ---------------------------------------------------------------------- 1 | ERROR | [ ] An error occurred during processing; checking | | has been aborted. The error message was: | | Undefined array key "scope_condition" in | | /var/www/html/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Sniffs/ControlStructures/SwitchDeclarationSniff.php | | on line 157 149 | ERROR | [x] There must be no space before the colon in a | | CASE statement 165 | WARNING | [ ] Line exceeds 80 characters; contains 84 | | characters ----------------------------------------------------------------------
I guess the first error is related to the second one. Probably fixing the second error will fix the first one.
Thanks
- last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - Status changed to Needs review
over 1 year ago 5:00am 5 September 2023 - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - last update
over 1 year ago Composer require failure - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - last update
over 1 year ago 367 pass - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the update. Can you please rebase the patch due to the previous merge? Thanks
- Status changed to Needs work
over 1 year ago 4:27am 6 September 2023 - last update
over 1 year ago 367 pass - Status changed to Needs review
over 1 year ago 8:30am 6 September 2023 - Status changed to Needs work
over 1 year ago 9:26am 6 September 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Sorry, can you please rebase the patch again due to the previous merge? Thanks
- last update
over 1 year ago 367 pass - Status changed to Needs review
over 1 year ago 1:21am 7 September 2023 - Status changed to RTBC
over 1 year ago 3:33am 7 September 2023 - πΊπΈUnited States yas California πΊπΈ
@ryo-yamashita
Thank you for the update. I'll merge the patch to
5.x
and6.x
, and close this issue as Fixed. - last update
over 1 year ago 367 pass -
yas β
committed 0ed1d520 on 6.x authored by
Ryo Yamashita β
Issue #3385104 by Ryo Yamashita, yas: Fix the form to delete OpenStack...
-
yas β
committed 0ed1d520 on 6.x authored by
Ryo Yamashita β
-
yas β
committed 3c0f77d7 on 5.x authored by
Ryo Yamashita β
Issue #3385104 by Ryo Yamashita, yas: Fix the form to delete OpenStack...
-
yas β
committed 3c0f77d7 on 5.x authored by
Ryo Yamashita β
- Status changed to Fixed
over 1 year ago 3:43am 7 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.