Fix MR testing

The error message that's thrown is just the generic one that happens when Composer can't find a package that matches what's required. In this case, it's trying to require the branch from the fork. I don't know anything about how the test system interacts with issue forks. I assume there's some layer in the D.o packagist that resolves forks for the purposes of testing. My thought was that maybe it's conflicting with whatever allows requirements for drupal/aggregator to be translated to the drupal/aggregator-aggregator that's in the module's composer.json file.

So I changed the name to be drupal/aggregator. I actually didn't expect this to pass. I thought it would probably be the type of composer.json change that doesn't work until it's committed. But it looks like this is the source of the problem. It seems like forks can be detected for the purposes of testing. Yet it doesn't know anything about translating drupal/aggregator into drupal/aggregator-aggregator.

I know that the name change was made due to a conflict with Drupal Core. I wonder if the name can be changed back for a 10.x-compatible branch, which I assume doesn't replace drupal/aggregator anymore.

I'll ask in the #drupalorg channel on slack

https://drupal.slack.com/archives/C5ABFBZ5Z/p1693803970113009

@larowlan Thank you for asking about it. I created a Slack account so that I can read or participate in the conversation.

The conversation in Slack pointed to the output of composer show, which is:

composer show -a drupal/aggregator
Info from https://repo.packagist.org: #StandWithUkraine
name     : drupal/aggregator
descrip. : Ingest RSS feeds into your Drupal site
keywords : 
versions : 10.0.0-alpha2, 10.0.0-alpha1, 9.4.3, 9.4.2, 9.4.1, 9.4.0, 9.4.0-rc2, 9.4.0-rc1, 9.4.0-beta1, 9.4.0-alpha1, 2.x-dev, 2.0.2, 2.0.1, 2.0.0, 1.x-dev, 1.0.2, 1.0.1, dev-1.x, dev-2.x
type     : drupal-module
license  : GNU General Public License v2.0 or later (GPL-2.0-or-later) (OSI approved) https://spdx.org/licenses/GPL-2.0-or-later.html#licenseText
homepage : https://www.drupal.org/project/aggregator
source   : [git] https://git.drupalcode.org/project/aggregator.git 6ba06f4a8c78f4b57841d664c473a0325697ea19
dist     : []  
names    : drupal/aggregator

support
source : https://git.drupalcode.org/project/aggregator

requires
drupal/core ^9.4 || ^10
laminas/laminas-feed ^2.17

So what I'm getting from that output is we shouldn't have a problem with implementing this change for D10-compatible versions, right?

I think this is fine for 2.x branch

@larowlan I'm sorry. I intended to credit you on the MR commit, but I didn't know what I was doing. I expected GitLab to work like GitHub and prompt me for a new commit message when squashing. But apparently it doesn't. I have more to learn about GitLab. Thank you for helping me look into this.

Automatically closed - issue fixed for 2 weeks with no activity.