- Issue created by @ssantaeugenia
- πͺπΈSpain ssantaeugenia
The previous patch is not applied for the new version of the 2.1.x module. I have the need to do the table suggestion because I need to modify the of the table and the
- First commit to issue fork.
- @matthieuscarset opened merge request.
-
matthieuscarset β
committed 3e34403d on 2.1.x
Resolve #3384508 "Add calendarviewthemesuggestionstablealter"
-
matthieuscarset β
committed 3e34403d on 2.1.x
- Status changed to Fixed
over 1 year ago 9:15am 15 September 2023 Moltes grΓ cies for filling this feature request.
It is implemented on 2.1.x and will be release soon.
Marking this as fixed. Feel free to reopen it if there's more work to do.
- πͺπΈSpain ssantaeugenia
It's great that it can be implemented in the module. I have updated the module without my patch and it does not work. In hook_theme_suggestions_table_alter you don't get the new view attributes inside $variables, I think you need to add the 3 new attributes in buildTable() of both month and week. I am attaching screenshots and a new patch in case it helps.
Before patch
After patch
- Status changed to Active
over 1 year ago 12:20pm 18 September 2023 - Status changed to Needs review
over 1 year ago 1:05pm 18 September 2023 Strange. I do have attributes on any calendar table (e.g. month and week).
Can you make sure you are on the latest version
2.1.4
?Also, can you make sure you cleared all caches?
- πͺπΈSpain ssantaeugenia
Yes, I have the latest version of the module and I have cleared all the caches. My drupal version is the latest (10.1.3), maybe that's it?
Strange... I do have suggestions on Month and Week calendar views.
See attached screenshot.
As of 2.1.4, I do not see any reason why the suggestions would not be available and the attributes not set π€·.
Maybe something with your theme and/or preprocess somewhere in your codebase?
- Status changed to Postponed: needs info
about 1 year ago 8:12am 19 September 2023 - πͺπΈSpain ssantaeugenia
Yes, I have the latest version of the module and I have cleared all the caches. My drupal version is the latest (10.1.3), maybe that's it?
- πͺπΈSpain ssantaeugenia
It seems that the new version 2.1.5 fixes the problem. Thanks for your great job.
- Status changed to Fixed
about 1 year ago 8:39am 20 September 2023 Nice. I guess somehow your codebase was not updated to 2.1.4 correctly or you were hitting cache.
Its good to know it is fixed now anyway.
Thanks again for reporting the issue.
Automatically closed - issue fixed for 2 weeks with no activity.