Deprecation of the use of theme_ functions, causes module to break sites

Created on 30 August 2023, 10 months ago

Updated 31 August 2023, 10 months ago

Problem/Motivation

When enabling this module on a drupal 9+ site you will create a white screen error because the fivestar_preview theme element uses the old 'function' method of applying updates to the code. I have updated the module to instead use template_fivestar_preview_preprocess to apply the same changes, and remove the 'function' array key from the hook_theme definition of this theme element.

Steps to reproduce

Enable the module on any drupal 9 site, and visit the any page. View error logs and you will see the Deprecation notice about this.

Proposed resolution

Apply included patch.

Remaining tasks

Review patch for standards and apply.

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report

Status

Closed: duplicate

Version

1.0

Component

Code

Created by

🇺🇸United States cmcintosh

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @cmcintosh
Comment 10 months ago →
🇺🇸United States cmcintosh
Attaching patch for this issue.
Status changed to Closed: duplicate 10 months ago11:25am 31 August 2023
Comment 10 months ago →
ivnish Poland
Duplicate of https://www.drupal.org/project/fivestar/issues/3287600 📌 Drupal 10 compatibility fixes Fixed

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024