Splide v4

You are correct.

I haven't been able to do the migrations, yet.

Patches are very much welcome.
Or if anyone would like to sponsor 2-3 hours, please get in touch.

Thank you.

That is totally fine. It just had not been mentioned yet, and I assumed there were a few things needed to accomplish the migration that might warrant a ticket.

If I find some time I might take a crack at the simple stuff like documentation, updating the relevant files from the library, etc. I just started yesterday so I am not super familiar with this module or Splide itself.

With that said, rather than commit this to 1.0.x, it might be good to cut a new dev branch, and update this ticket so MRs will go against that instead.

Agreed, Splide v4 has a breaking change not easily synced with v3, better in 2.x :)

Elevating it to Task, since we got a sponsor for this feature, thanks to Karl. We'll put their username at project home on their permission later.
I am still reading the changes for now, and change a few little things accordingly.

Initial attempt, expect a few misses.

The autoplay and progress bar can be placed anywhere as per design requirements.
However the current implementation consider the most complex layering and positioning like seen in the screenshot, not the best UX, just minor considerations were taken when placing the autuplay button against other slide controls.

Minor refinements with camelCase for the plugins.

Fixed for CS, and pagination height regressions.

Temporary commit so to spot potential regressions and misses better.

Added Breaking changes section.

Marking this a NW for a temporary workaround or solution since the Breaking changes do break existing installs.

Added few more breaking changes, and remaining tasks.

Fixed for few breaking changes.

I intentionally kept old v3 Html structure to avoid too much work, and minimize breaking changes on my or your own personal projects.
We'll consider updating it perhaps at splide.module:3.x, but not during this v4 migration.

• Fixed for stylelint auto fix bad moves.
• Fixed for perPage > 2 having empty clones on LHS, seen at asNavFor, carousel, etc.

Somebody likely me just forgot to upload the patch.

Leaving it to NR before closing this, in case I missed the obvious.

If anyone are willing to test out the latest DEV, which may work with blazy:2.18, your reports are also very much appreciated.
We'll have an initial alpha or beta this week after another check.

Thank you.

Initial test looks good! I have one complicated slider on this build I'm half finished with that mostly worked the same, and then some others I haven't really worked on yet but they all seem to work the same as they did before with defaults.

Adding a new breakpoint to an existing optionset seems buggy, it's overriding an existing one. I'm not sure if that's a new issue with 2.x however.

Thank you.

Mind pasting your exported splide.optionset for further checks? I need the exact buggy optionset to be on the same page.

> Adding a new breakpoint to an existing optionset seems buggy, it's overriding an existing one....
Yes, I am still figuring out the reasons behing this change. v4 does bubble up the settings as mentioned in their docs and quoted in issue summary, causing Breaking changes #1. I had solved the most obvious Destroy issue as otherwise desktop slider is destroyed as well. Must re-check other bubbling issues.

There is an option Media query, not sure if it solves this issue if changed from min to max. Worth looking, though.

Aside from destroy, the obvious breaking Splide X: Carousel sample. It used to show 5 perPage as designed, but now only 3 until Media query is changed to max.

I am thinking the default Media query should be max to avoid preserve v3 with anything else like perPage, destroy, etc.

Could you confirm, that is the case so we can update min to max for optionsets once?

I just noticed it happened since v3 specific for perPage. It got away from v2 update likely.
Only v4 is more expansive even to destroy.

perPage is 7 on desktop, 5 for 769px and 3 for 481 as seen in the sample:
/admin/config/media/splide/x_splide_nav
https://git.drupalcode.org/project/splide/-/blob/1.0.x/modules/splide_x/...

They were fine in v2 if you downgrade it. It starts breaking in v3.

Based on https://splidejs.com/v3/guides/version3/

I think this feature line got away from attention during migration from v2 to v3:
> Support the min-width media query for breakpoints

Not checked yet, but I guessed that if I add Media query min to each breakpoint should fix this perPage, destroy, etc issues. Better than making all min to max.

That exact line should explain the sample issues with v3 which were fine v2.

On second thought, adding Media query option to each breakpoints sound like chaos, min max would be jumbled if any values were mixed up. I don't know how to sentence such chaotic situation better in English :)

The old v2 with a single base Media query to dictate the entire breakpoints sound more reasonable.

Changed default mediaQuery to max.

An oversight during v2 to v3 migration:
https://splidejs.com/guides/options/#breakpoints
> A collection of responsive options for specific breakpoints. By default, Splide uses max-width(desktop-first) to check the device width, but you are able to change it to min-width (mobile-first) by mediaQuery.

We'll need to back-port this to splide:1.x with v3 later, but splide:2.x should be fine now.

FYI:
#32 didn't update user defined optionsets, except for default.

Should be no issues if you always check Optimized option like all the samples so to automatically fetch defaults, otherwise you may want to tick that Optimized option to correct it automatically.

I think I am fairly happy with the most fundamental issue oversight just found from v2 to v3 upgrade, and so inherited in v4.

Initial 2.x was just out. Any other issues can be reported as regular project issues.

Again head-ups:
Should be fine with Blazy:2.19+ since Blazy:3.x is not out, just yet.

Thank you all, and @KarlShea for sponsoring this, without which, I might be a bit of lacking of motivations :)

> Yes, I am still figuring out the reasons behing this change. v4 does bubble up the settings as mentioned in their docs and quoted in issue summary, causing Breaking changes #1. I had solved the most obvious Destroy issue as otherwise desktop slider is destroyed as well. Must re-check other bubbling issues.

Oh sorry, I wasn't super clear, I meant in the Drupal UI. But I think it was a false alarm, I tried to reproduce the issue where saving wouldn't update the number of breakpoints and I think I had just messed up the options myself!

Automatically closed - issue fixed for 2 weeks with no activity.