- Issue created by @nessthehero
- Assigned to Balu Ertl
- @balu-ertl opened merge request.
- Status changed to Needs review
about 1 year ago 4:07pm 8 October 2023 - 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
A first draft solution is ready for testing on the merge request. The only deviation from the requirements defined in the ticket description is that all media bundles defined by this module have their previews displayed on their subtype editor pages:
The reason why I left the MR in Draft status is that there are a couple of points to possibly further improve the feature:
- We could use a Twig template for rendering the markup instead of concatenating raw HTML only. If going this way, then some label above the image could be useful.
- Decide on which terminology, “preview” or “thumbnail” shall we use for this image. I believe abiding by naming conventions matters.
- Probably test coverage would be necessary as well.
Also updating IS regarding the changes.
- Status changed to Needs work
about 1 year ago 8:05pm 16 October 2023 - 🇺🇸United States mglaman WI, USA
This needs work. It can be simplified using existing checks to see if a media type has our source plugin.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 2:54pm 2 November 2023 - 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
The default
acquia_dam_asset_item
widget plugin has been extended with an extra render array item of the thumbnail image which is being fetched directly from the remote DAM software.
→(Drupal keeps local copies of thumbnails as managed files only for displaying them on entity lists but not on entity forms.)
- last update
about 1 year ago 199 pass - Status changed to RTBC
about 1 year ago 1:28pm 6 November 2023 - 🇺🇸United States nessthehero
I can only test the "DAM - Image" content type since I don't think we have any other kinds of content in our DAM (and I don't have the ability to create/add assets to it), so I can mark this as RTBC for that aspect!
Excellent work! It should be documented somewhere that in order for the thumbnail to appear, you have to move the "Asset Reference" field out from the disabled fields on the Form Display settings for the DAM - Image media type.
Thanks!
-
japerry →
committed e5f1a4af on 1.0.x authored by
Balu Ertl →
Issue #3384273 by Balu Ertl: Include image on edit media detail screen...
-
japerry →
committed e5f1a4af on 1.0.x authored by
Balu Ertl →
- Status changed to Fixed
about 1 year ago 7:38am 8 November 2023 - 🇺🇸United States japerry KVUO
We'll look at adding it as default later on. so for now, fixed!
- Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
12 months ago 8:59am 23 November 2023