Contrib.social

Update Meilisearch dependency to a recent 1.x series version

Open on Drupal.org →
Created on 29 August 2023, about 1 year ago
Updated 11 September 2023, about 1 year ago

Problem/Motivation

Several issues in the queue show there is a need to support more recent releases of Meilisearch.
There are a few locations in the current implementation of this module that either work around shortcomings or older functionality or even state that there are problems with the currently supported version 0.28.1

Proposed resolution

The current issue queue has some tickets left that do not seem too related to the actual version of Meilisearch used. To keep concurrent changes low, the consensus is to first implement those.

After this, the dependencies (Meilisearch server itself, meilisearch/meilisearch-php) shall be updated and tests shall be run to verify whether (recent) code is forward compatible.

If this is the case, workarounds for older APIs can be removed and features can be added that simply have not been possible with previous versions.

This issue serves as a collection for issues that need to be fixed before the upgrade can be performed and for those that can be tackled afterwards.
Feel free to add any issues I may have forgotten!

Remaining tasks

  • Update Meilisearch to the latest stable version when starting this issue.
  • Update meilisearch/meilisearch-php to the latest stable (which has to be compatible with the Meilisearch server version used; this is mostly the case a few days after the Meilisearch server release). Note that

Issues that should to be fixed before (they seem pretty complete already; not all of them are hard prerequisites, so some could be postponed to after the upgrade as well):

Issues that can be started after an update, i.e. follow-up issues:

  • 📌 Include test for a search with an empty field condition Fixed
  • TODO: I am sure there are things missing here as I only know parts of the code and am no real dev :( There are no open issues that are actually created at this time, but I am pretty sure there should be some.

Do we want a new version for this?

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇦🇹Austria tgoeg

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @tgoeg
  • Comment about 1 year ago →
    🇦🇹Austria tgoeg
  • Comment about 1 year ago →
    admirlju
  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇸🇮Slovenia bcizej

    Unblocked and ready to be pushed forward

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    106 pass, 1 fail
  • @bcizej opened merge request.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    109 pass
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇸🇮Slovenia bcizej

    Suprisingly there were very few things needed to fix, so I updated all links as well and changed MeiliSearch to Meilisearch wording wherever I could find. Ready for test.

  • First commit to issue fork.
  • Comment about 1 year ago →
    🇸🇮Slovenia DeaOm

    The new version of meili changed their naming from MeiliSearch to Meilisearch and the namespaces were not updated to match that, so changed that. Also updated one see link, to point to the new documentation. For whatever reason, locally the QueryFilterTest the testFiltersWithSpecialCharacters is failing for me, but here it seems it passes. I'm not to worried about it, as we do have an issue where this will be retested again. From my POV can be merged, but will leave it to needs review.

  • Comment about 1 year ago →
    🇸🇮Slovenia bcizej

    The new version of meili changed their naming from MeiliSearch to Meilisearch and the namespaces were not updated to match that, so changed that.

    Good catch, thanks.

    For whatever reason, locally the QueryFilterTest the testFiltersWithSpecialCharacters is failing for me, but here it seems it passes.

    Did you update the meilisearch docker image to v1.3.3? The only reason I see tests failing locally is with v0.28.1 as the parser was updated to escape backslashes properly.

  • Comment about 1 year ago →
    System Message
    • bcizej → committed 019e5f92 on 2.x 
      Issue #3383952 by bcizej, DeaOm, tgoeg: Update Meilisearch dependency to...
  • Status changed to Fixed about 1 year ago
  • Comment about 1 year ago →
    🇸🇮Slovenia bcizej

    Merged, thanks.

  • Comment about 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024