- Issue created by @tgoeg
- 🇸🇮Slovenia bcizej
Is there anything apart from the test that needs to be changed and/or is it possible to add more functionality to this module once Meilisearch supports those operators? A follow-up issue needs to be created, then.
We will need to create more operator parsers here to deal with these. We don't add an attribute to the document if the value is empty but I am not sure if that also means empty strings (will have to test). So we will definitely need an EXISTS operator parser and depending on if we add empty strings to the document then also IS_EMPTY parser will have to be added.
- Status changed to Needs work
over 1 year ago 3:11pm 11 September 2023 - @bcizej opened merge request.
- Status changed to Needs review
over 1 year ago 6:31pm 11 September 2023 - 🇸🇮Slovenia bcizej
Used EXISTS operator for null value operator parser and uncommented tests
- 🇸🇮Slovenia deaom
The tests are also passing locally, but when manually testing, not sure if I'm doing something wrong, but if I add the "search full text search" with the empty field filter, I don't get correct results, if I search with the "full text search filter empty" then I get results if filter is also empty, when testing is empty.
For example, entity title is New entity, subtitle for this entity is empty. The condition are search full text New entity, subtitle filter is empty. I would expect to only get New entity as a result, but I get no results. If I then leave the full text search filter also empty and of course also subtitle, I then get all entities, that have empty subtitle. This part then works correctly. Not sure if it should work together like that. So leaving to needs review for now. If this is how it's suppose to work, then see no issues with this being merged.
- Status changed to RTBC
over 1 year ago 8:51am 12 September 2023 - 🇸🇮Slovenia deaom
Re-tested because tests were passing, so manual testing needed to be wrong and it was. Basically the fulltext type was set on the wrong field. After changing that, everything works as it should, so marking it RTBC.
- Status changed to Fixed
over 1 year ago 5:52pm 12 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.