Refactor action button labels of the OpenStack floating IP detailed view in SPA (drupal/cloud_dashboard)

@yas

Please review it. Thanks.

@ryo-yamashita

Thank you for fixing the issue. I posted my comment. Thanks

@yas

To prevent hard-coding of logic, I cut out the possible processing for each type of entity as constant data. This allows for easy addition of functionality. Thanks.

@ryo-yamashita

Thank for the update with the refactoring. I like the refactoring. I think menu_operations.ts can be separated to menu_operations.ts and menu_operations.json like the existing menu_template.ts and menu_template.json.

Or the JSON file can be the one used for both menu_template.ts and menu_operations.ts.

What do you think?

@yas

menu_template.json has a history of being automatically generated from an existing YAML file.

Therefore, it is possible to integrate the information in this file with menu_template.ts.

However, until the possibility of significant additions to menu_template.json arises, I don't see the need to refactor it yet. It is assumed that this issue can be closed as is. Thanks.

Note: If the contents of the data part of menu_operation.ts is separated into JSON, we will not be able to benefit from type inference when adding to the data part in the future. Therefore, there seems to be no particular advantage to creating menu_operation.json.

@yas

To improve the readability of menu_operations.ts, the type definitions have been moved to the model directory. This makes menu_operations.ts easier to write. Thanks.

@ryo-yamashita

Thank you for the update. I like the refactoring. Please rebase the patch. Thanks

@ryo-yamashita

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.