Uncaught TypeError: Drupal\commerce_payment\PaymentOrderUpdater::updateOrder(): Argument #1 ($order) must be of type Drupal\commerce_order\Entity\OrderInterface, null given,

@tonytheferg: Maybe adding this check doesn't hurt... However I think there's a problem with your migration as it shouldn't trigger this logic...

Totally Agreed. it's the timing of the rollback.

but maybe there is a small chance somehow programatically creating or deleting payments/orders might trigger the error.

I needed the patch for my hackery anyhow. 🤣

We've had the very same issue unrelated with migration and it looks like there's something wrong with how PaymentOrderUpdater
works.

The thing is you may only see this error on the console when using cron as it is triggered from PaymentOrderUpdater::destruct(), maybe it doesn't even get into the logs as it is produced when the request is being destroyed.

It happens when you delete a commerce order from some cron process. Then PaymentOrderUpdated keeps the order id cached, but fails to reload the order, that was deleted, when doing the clean up operations...

And yes, the patch fixes the issue, or at least prevents the error, which I'd say is a very bad one as it can go hidden for a long time and have very unexpected consequences, since it prevents the request from being properly terminated...

Automatically closed - issue fixed for 2 weeks with no activity.