Views shows multiples results for the same vote when is enabled content translation

Patch ready, I did not add an update, but maybe should be necessary to override the existing configuration.

Hi,

Thanks for the contribution. It's a little hard for me to review it because it seems that most of the changes are just re-arranging parts of the .yml file. For example. these hunks:

@@ -1380,23 +1389,11 @@ display:
         - user.permissions
       tags: {  }
   node_page:
-    display_plugin: page
     id: node_page
     display_title: 'Entity Votes'
+    display_plugin: page
     position: 2
     display_options:
-      display_extenders: {  }
-      path: node/%node/votes
-      menu:
-        type: tab
-        title: Votes
-        description: ''
-        expanded: false
-        parent: ''
-        weight: 0
-        context: '0'
-        menu_name: main
-      display_description: ''
       arguments:
         entity_id:
           id: entity_id
@@ -1405,6 +1402,9 @@ display:
           relationship: none
           group_type: group
           admin_label: ''
+          entity_type: vote
+          entity_field: entity_id
+          plugin_id: numeric
           default_action: default
           exception:
             value: all
@@ -1420,8 +1420,8 @@ display:
           summary_options:
             base_path: ''
             count: true
-            items_per_page: 25
             override: false
+            items_per_page: 25
           summary:
             sort_order: asc
             number_of_records: 0
@@ -1433,18 +1433,32 @@ display:
           validate_options: {  }
           break_phrase: false
           not: false
-          entity_type: vote
-          entity_field: entity_id
-          plugin_id: numeric
-      defaults:
-        arguments: false
-        filters: false
-        filter_groups: false
       filters: {  }
       filter_groups:
         operator: AND
         groups:
           1: AND
+      defaults:
+        relationships: false
+        arguments: false
+        filters: false
+        filter_groups: false
+      relationships: {  }
+      display_description: ''
+      display_extenders:
+        metatag_display_extender:
+          metatags: {  }
+          tokenize: false
+      path: node/%node/votes
+      menu:
+        type: tab
+        title: Votes
+        description: ''
+        weight: 0
+        expanded: false
+        menu_name: main
+        parent: ''
+        context: '0'
     cache_metadata:
       max-age: -1
       contexts:

I *think* the only real change made by these hunks are the addition of:

       defaults:
+        relationships: false

and
+ relationships: { }
and

-      display_extenders: { }
+      display_extenders:
+        metatag_display_extender:
+          metatags: {  }
+          tokenize: false

but I am not completely sure. Everything else in there looks like things that have just been reordered.

I suspect that most of these changes are core Views changes in the config schema and the way core Views orders the config properties, and I suspect that the actual functional changes made by this patch are very few? I think the relationships and metatag_display_extender items are new properties defined by Views in the three years since views.view.votingapi_votes.yml was created.

If possible, can you separate these changes into two patches?
The first patch would be just to update views.view.votingapi_votes.yml to the current views format/properties. I suspect this will be the majority of the changes. I think that can be done just by exporting the view and doing a diff between the export and the version that is distributed with Voting API. That could be committed first. Then the second patch would be just the changes needed for your bug fix, which I think are relatively few.

Can you also look at #2638366: Votes not displayed when module "content translation" activated → which also involves the content translation module and a similar error?

Actually, the metatag_display_extender property looks to be something specific to your site, because you have the Metatags module enabled?

Thank you @TR, you are totally right, I will try to export it in two patches removing parts not related to the voting as you said.

Well, the issue #2638366: Votes not displayed when module "content translation" activated → is from 2015 without any update or comment from other users and is from Drupal 7, so maybe I would close the issue.

Yes, I'm not so concerned about D7 at this point, but I assume that if it was a problem in D7 it's probably also a problem in D8+, so if it's simple to test I would like to see if this problem still exists in the current version of Drupal/Voting API before I dismiss that old bug report.

I upload the patch voting_api-3383319-views-drupal-clean-nochanges-11.patch → after installing the votingapi on a drupal 9 clean, without other modules and exports the view, there are no deletions or additions, only changes in the ordering.

I also update the real changes interdiff_only_views_changes.txt → , I remove the relationships on the "Entity votes" because is not necessary, and add the group by to both view pages.

I updated the current patch removing metatags.