- Issue created by @Ruslan Piskarov
- @ruslan-piskarov opened merge request.
- Status changed to Needs review
about 1 year ago 7:04am 25 August 2023 - Assigned to Jay Jangid
- Issue was unassigned.
- 🇮🇳India Jay Jangid
I have examined and applied the merge request provided by @Ruslan Piskarov.
The merge request has been successfully implemented.
As a result, 't()' has been replaced with '$this->t()'.
Thank you. - 🇳🇴Norway gisle Norway
Jay Jangid, your comment doesn't make sense.
You don't have the required access level to apply a merge request to the project (only a project maintainer can do that), and there is no record of anything having been applied.
- 🇺🇦Ukraine Ruslan Piskarov Kiev, Ukraine
I think @Jay Jangid wanted to write: he applied the path on local and reviewed.
- 🇳🇴Norway gisle Norway
Well, he might have applies it locally, but there is no real review. He just says that it applies and that it did the edits it were supposed to do. I would not have expected anything less. Whether the module still worked after applying the MR, and if there were any side-effects goes unsaid.
Btw., I appreciate your MR, and hope to find time to test it soon.
-
gisle →
committed 5741bdc7 on 2.0.x authored by
Ruslan Piskarov →
Issue #3383285: Replace t() with $this->t() for Drupal 8+ version
-
gisle →
committed 5741bdc7 on 2.0.x authored by
Ruslan Piskarov →
- Status changed to Fixed
about 1 year ago 12:41pm 17 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.