Created on 23 August 2023, about 1 year ago
Updated 28 August 2023, about 1 year ago

Problem/Motivation

It looks like this module uses hard coded paths because I am using following module rename_admin_paths β†’ and it is not possible to load content/taxonomy with this module due to following issue :

it says :
page not found > /admin/entity_reference_tree/json/node/*?token=ah6VuHAc8JmyFSY...

it is possible to configure paths generated by the route as described in rename β†’ ?

When I disable rename admin path it works fine.

✨ Feature request
Status

Fixed

Version

2.2

Component

Code

Created by

πŸ‡ΈπŸ‡°Slovakia coaston

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @coaston
  • Status changed to Closed: works as designed about 1 year ago
  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί

    This is not a bug as it works as designed.

    I am not familiar with rename admin paths module, but the all the routes created by Entity Reference Tree Widget module are defined in

    https://git.drupalcode.org/project/entity_reference_tree/-/blob/2.2.0/en...

    Nothing hardcoded and you should raise your question about your custom path to rename_admin_paths module. There is nothing to do with a custom path here, as this module doesn't provide this functionality.

  • Status changed to Active about 1 year ago
  • πŸ‡ΈπŸ‡°Slovakia coaston

    First of all, thank you for your answer. However you are not right I guess.

    Rename admin module has following description :

    If another module is no longer functional after this module is enabled this usually means that the other module uses hard coded paths instead of paths generated by the router with a route name. This is not something that can and should by fixed by this module.

    The same question was raised for a different module here 3349859 πŸ› Cannot save model when module rename_admin_paths is active Fixed and maitanier was able to provide quick fix, even they are using the same approach with /admin but fix here :wrong-url looks quite easy.

    Hence I am asking you to double check and possible do the similiar path here to make this module compatible.

    Thank you for your understaning.

  • Status changed to Closed: works as designed about 1 year ago
  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί
  • πŸ‡ΈπŸ‡°Slovakia coaston

    Well, looks like you gave up, but still thanks for your time.
    Not sure how to explain it more that this needs to be fixed in this module to make it compatible. So far it works with all contributed modules, except this one, so this is also trigger that any config is not right there.

    Now I need to decide whenewer to disable this awesome module ,or another admin one, which is also awesome.

    However, good work - this module is powerful!

  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί

    First of all, my module is not responsible for the functionality provided by other modules. In this case, a custom path feature is not my module is responsibility.

    Secondly, I have already pointed to where exactly the path you mentioned is created. If you don't even give a look at what I said, then constantly said it is 'Hard Coded' without any evidence. That is unacceptable.

    Here is the code snippets that creates the path.

    path: '/admin/entity_reference_tree/json/{entity_type}/{bundles}'
    

    And spend some time to learn the Drupal routing system ( https://www.drupal.org/docs/drupal-apis/routing-system/structure-of-routes β†’ ), if you don't know what the above codes mean. You should learn it first, then tell others what is 'Hard Coded'.

    I close this again as the module works as design. You open it for three times, I will report you as spam.

  • Status changed to Fixed about 1 year ago
  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί
  • πŸ‡¦πŸ‡ΊAustralia mingsong πŸ‡¦πŸ‡Ί
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024