GoogleTagUpgradeManager not mapping negate values correctly

The attached patch updates GoogleTagUpgradeManager::convertConditions() so that 8.x-1.x "xxxx_toggle" config setting values are mapped to 2.0.x negate values as follows:

• xxxx_toggle: 'include_listed' is mapped to negate: false
• xxxx_toggle: 'exclude_listed' is mapped to negate: true

After further testing, I realized that value of the $negate_toggle variable that GoogleTagUpgradeManager::convertConditions() uses to compare to values it's migrating ('exclude_listed') does not actually match the value of the GOOGLE_TAG_EXCLUDE_LISTED constant used in 8.x-1.x ('exclude listed'). This updated patch addresses that problem as well.

Updated issue summary with additional findings from #5.

Yah, that looks right. Not really wanting to write upgrade tests, but per slack you said this is working better so I've committed it to head. Thanks for the help!

Thanks @japerry! Made some minor clarification updates to issue summary.

Can this please be tagged and released so that people doing the upgrade to 2.0.x don't unintentionally break their integrations?

Automatically closed - issue fixed for 2 weeks with no activity.

This regression really breaks the proper functioning of the module!

If you have anonymous users checked under user role and this condition is reversed after the 2.x update, then you are basically tracking no users at all.

I'm using config management and I didn't see it.

I agree with bramvandenbulcke, this is a regression and will cause data collection loss for those who upgrade.
The fix has been in dev for 5 months, can we get a new release?