- Issue created by @jurgenhaas
- Status changed to Needs review
10 months ago 9:42am 23 August 2023 - Status changed to RTBC
10 months ago 9:58am 23 August 2023 - π©πͺGermany jurgenhaas Gottmadingen
This does the job. I'm just uncertain why that if-statement is even required in the first place.
SmartDateRule::loadMultiple($ids)
never returns anything other than a list of SmartDateRule entities. So why checking?However, if there's a reason that I don't see, as for the purpose of this issue, this patch fixes it and is RTBC.
-
mandclu β
committed a5136ff5 on 4.1.x
Issue #3382603 by mandclu: Cron in smart_date_recur not working due to...
-
mandclu β
committed a5136ff5 on 4.1.x
- Status changed to Fixed
10 months ago 10:10am 23 August 2023 - π¨π¦Canada mandclu
The check was added in #3281805: smart_date_recur_cron() - runs into an error β to resolve an error that creating problems during cron runs. I never actually uncovered the source of the error, but validating that the necessary data is available seems reasonable enough.
Thanks for the quick feedback, merged in these changes.
- Status changed to RTBC
10 months ago 10:41am 23 August 2023 - π©πͺGermany jurgenhaas Gottmadingen
Thanks for fixing this. The data check was probably necessary if the format of the entity changed some time back. Never mind, should be OK now.
- Status changed to Fixed
10 months ago 11:16am 23 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 2 months ago 12:41pm 7 May 2024 Since the previous queue wasn't working properly, you might be in a situation where the next queue is scheduled to run in 7 days time, which means that a manual reset might be required in order to process them as soon as possible:
drush php-eval '\Drupal::state()->set("smart_date_recur_check", 0);'