If there are no 'projectWikiValueObjects', return early

Created on 22 August 2023, over 1 year ago
Updated 25 August 2023, over 1 year ago

Problem/Motivation

Currently, when entering the project wiki page, the search bar is rendered and js errors get thrown. Instead,

If there are no 'projectWikiValueObjects', return early and render a disclaimer text instead of the 'project_wiki_list' theme.

Steps to reproduce

Go to '/admin/help/wiki' without any wiki entries created.

Proposed resolution

Return early.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Closed: duplicate

Version

1.0

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Grevil
  • 🇩🇪Germany lrwebks Porta Westfalica
  • Status changed to Needs work over 1 year ago
  • 🇩🇪Germany lrwebks Porta Westfalica

    Tackling it now in its parent issue!

  • 🇩🇪Germany lrwebks Porta Westfalica

    Apparently the JS errors have nothing to do with the list being empty, as they also appear when there are entries in the list. They seem to be connected to ListJS as it stopped working.
    I will both fix the issue and add the proposed disclaimer text, don't worry!

  • Status changed to Needs review over 1 year ago
  • 🇩🇪Germany lrwebks Porta Westfalica

    Disclaimer message has been added! No need to escape early, since these JS errors were not related to the list being empty (they occur if a required library for ListJS is not installed) and an empty list throws no errors at all now.
    Please review in the 1.x branch within the parent issue!

  • Status changed to RTBC over 1 year ago
  • 🇩🇪Germany Grevil

    Fixed in the parent task, well done!

  • 🇩🇪Germany Grevil

    Note, that I meant to return early, so that the search bar isn't rendered at all, when there are no entries in the project wiki. This is more performant, since we do not need to attach the library, and looks a bit more polished. Setting back to needs work and removing the parent issue.

  • Status changed to Needs work over 1 year ago
  • Status changed to Closed: duplicate over 1 year ago
Production build 0.71.5 2024