- Issue created by @wim leers
- Open on Drupal.org →Environment: PHP 8.2 & MySQL 8last update
over 1 year ago Not currently mergeable. - @wim-leers opened merge request.
- last update
over 1 year ago 586 pass - last update
over 1 year ago 536 pass, 1 fail - last update
over 1 year ago 586 pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:27am 22 August 2023 - last update
over 1 year ago 30,056 pass - Status changed to RTBC
over 1 year ago 4:08pm 25 August 2023 - 🇺🇸United States smustgrave
All green. Looking at the MR nothing stands out as bad.
Tried running tests without the fix but just got Error : Call to undefined method Drupal\Tests\ckeditor5\Kernel\ValidatorsTest::violationsToArray()
But think this is good to move on.
- last update
over 1 year ago 30,058 pass - last update
over 1 year ago 30,060 pass - last update
over 1 year ago 30,063 pass - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
This makes the original issue a bit simpler and it is a clear improvement. RTBC+1
- last update
over 1 year ago 30,130 pass - last update
over 1 year ago 30,135 pass - last update
over 1 year ago 30,136 pass - last update
over 1 year ago 30,136 pass - last update
over 1 year ago 30,146 pass - last update
over 1 year ago 30,146 pass 22:55 21:40 Running- last update
over 1 year ago 30,154 pass - last update
over 1 year ago 30,159 pass, 2 fail - last update
over 1 year ago 30,168 pass - last update
over 1 year ago 30,168 pass -
effulgentsia →
committed 4401dc2d on 11.x
Issue #3382453 by Wim Leers, smustgrave, borisson_: \Drupal\Tests\...
-
effulgentsia →
committed 4401dc2d on 11.x
- Status changed to Fixed
over 1 year ago 6:26pm 22 September 2023 - 🇺🇸United States effulgentsia
Pushed this to 11.x to unblock progress on 📌 Configuration schema & required keys Fixed , but the following seems redundant:
+ $actual_violations = self::violationsToArray($violations); + $this->assertSame($expected_violations, self::violationsToArray($violations));
Anyone want to file a quick issue to clean that up?
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
You mean that the variable
$actual_violations
is redundant?If so: I respectfully disagree: it's very helpful for setting conditional breakpoints 😇
It doesn't cost us performance, nor are end users affected since this is only for tests. So, I'm kinda hoping this is fine as-is. Still, happy to do what you're requesting if you disagree! 👍
- 🇺🇸United States effulgentsia
You mean that the variable $actual_violations is redundant?
No. Just that the 2nd line can be simplified to use that variable.
Automatically closed - issue fixed for 2 weeks with no activity.