4.4.x incompatible with mmenu 9.x

Created on 20 August 2023, 10 months ago
Updated 15 September 2023, 10 months ago

Problem/Motivation

The menu is always on-screen when using version of 9.3 of mmenu with the 4.4.x version of Responsive Menu.

Steps to reproduce

Install mmenu 9.3 with 4.4.x and the menu will always be on-screen. Replace with the latest version of mmenu 8.5.x and the menu works as designed.

Proposed resolution

The mmenu projects says that the 9.3 version has added a high-contrast mode, added keyboard navigation, improved accessibility and slimmed down the code (as well as replaced SCSS variables with CSS ones and other modernizations). It also removed all support for IE and recommends using the 8.5.x branch and polyfills if IE compatibility is needed.

If those features are needed, it seems that a 5.x branch of this module will be required. If not, this module continues to work well with mmenu 8.5.x.

Remaining tasks

Create plan for 9.3 compatibility likely by releasing 5.0 of this module. Note Fix failing test 📌 Fix failing test Needs review has a MR removing support for polyfills and was submitted before seeing this major version incompatibility. Probably the best way forward is to document that only the 4.x branch supports mmenu 8.x and polyfills (so download that) and that 5.x will support mmenu 9.x and that means the polyfill library won't be available.

🐛 Bug report
Status

Closed: duplicate

Version

4.4

Component

Code

Created by

🇺🇸United States aangel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024