- Issue created by @ipwa
- @ipwa opened merge request.
- 🇬🇧United Kingdom ipwa
In case anyone needs a patch for their composer file before this is released or in case maintainer prefers patches to MR.
- 🇺🇸United States generalredneck Texas, USA 🇺🇸
Ammending the steps to reproduce as the original is inaccurate.
- 🇺🇸United States generalredneck Texas, USA 🇺🇸
@ipwa,
A reminder also when you have posted work, Please mark it as "Needs Review". This will help me prioritize the queue for what needs testing. I'll try to get to it as my email will allow me since I get notified for all new issues in this queue, but you know... at a glance this looks like an open ticket with no solutions to review. Figure it was just a slip though.All that said, I tested the solution and looks like we are good to go!
- Status changed to RTBC
over 1 year ago 3:23am 20 August 2023 -
generalredneck →
committed eacd73fa on 2.x authored by
ipwa →
Issue #3382030 by ipwa: Drupal\Core\Http\RequestStack deprecation
-
generalredneck →
committed eacd73fa on 2.x authored by
ipwa →
- Status changed to Fixed
over 1 year ago 3:24am 20 August 2023 - 🇺🇸United States generalredneck Texas, USA 🇺🇸
Pushing this out as 2.0.1 since it's pretty much a hotfix. Should be ready soon.
- 🇺🇸United States generalredneck Texas, USA 🇺🇸
No problem. I can't promise it will always be that way as I am a maintainer on several modules.
I kinda expected to have something like this on this one since it was a large release, I'm unfamiliar with the specifics, and we have 0 automated tests. I'm really surprised that one didn't' show up on rector and that explains a fix I saw in the D10 MRs that someone else made... though this fix is MUCH preferred.
Thank you for being on top of testing it out and getting us a contributed fix quickly as well.
Automatically closed - issue fixed for 2 weeks with no activity.