- Issue created by @mariacha1
- πΊπΈUnited States AaronBauman Philadelphia
\Drupal\salesforce_mapping\SalesforceMappingFieldPluginBase::pushValue is supposed to handle this, so let's consider this a bug.
Also, see past discussion on π Mapped date fields are not properly syncing data. Closed: outdated
- πΊπΈUnited States mariacha1
Shoot, I didn't find that open issue! That's the same issue as this one in my opinion, although the patches there only deal with pushing. @AaronBauman I'm fine with closing this as a duplicate and moving patching over to there, if it's ok to also work on pulls in that issue too?
- πΊπΈUnited States AaronBauman Philadelphia
i think it's fine to keep both issues open, as that one has a lot of baggage already and is tagged on 4.x
- First commit to issue fork.
- Status changed to Needs review
11 months ago 5:11pm 9 February 2024 - πͺπΈSpain keopx Basque Country
I created the patch to transform SF data to the timestamp for created/changed value.
- Merge request !69Issue #3382005: Convert integers (like created/updated) to timestamps if... β (Open) created by keopx
- Status changed to Needs work
11 months ago 9:09pm 15 February 2024 - πΊπΈUnited States AaronBauman Philadelphia
Looping back around on this one.
AFAIK this MR addresses an impossible scenario - a "datetime" field from salesforce whose data is getting pulled as an integer.Salesforce stores datetime values as strings in iso8601 format, which is what the current
\Drupal\salesforce_mapping\SalesforceMappingFieldPluginBase::pullValue
method checks for.Maybe what we want is for the module to be aware of the Drupal field type and cast an integer value from Salesforce accordingly. That's a much bigger can of worms (ie. what other mis-matched field types do we want to support?), and not addressed by this MR as best I can tell.
- Status changed to Needs review
8 months ago 12:27am 21 May 2024 - πΊπ¦Ukraine knyshuk.vova
The attached patch adds timestamp value push support by converting timestamp into supported by Salesforce format.
The code originally from the last patch in old discussion branch https://www.drupal.org/project/salesforce/issues/3122412#comment-14116705 π Mapped date fields are not properly syncing data. Closed: outdated ,
additionally fixed bugs
- 'date' salesforce type converting
- possibly missing requested drupal field definition (due to 'drupal_field_value' may have not a drupal field name value)Tests coverage still needed.