Reply, Resolve, and special create permissions

I think more permissions are probably good, but I don't get the business use case of this one:

Able to create top level notes, only if the user can not edit the content. If the user can edit the content, they should fix the issue instead of leaving a note

Would users with this permission intuitively know why they can't leave a note on some entities but not all entities they have read access to? Maybe if you explain the use case more it'll make more sense to me. Thanks for the PR!

Hi Sam,

I'll get those items cleaned up.

About the special create permission. I want to use the screenshot from Moderation Notes as an example; This is 'spled' wrong
If the user can edit the content to fix the spelling, they should do so, instead of leaving a note, effectively asking someone else to fix it.

As an alternative to this, we could make it so that if you have access to view an entity you have access to leave a note, which would reduce the number of permissions out there.

Changing it to letting users notate content they can view won't provide the same result; users who can edit the content will still be able to leave notes.

I am not a huge fan on the permission name. If you have a better one I am all ears.

My users will know why they cannot leave a note, because there is a process/method and they go though training. I can really speak for other site builders, and I do not know what would make the reason more obvious.

I use moderation note with the knowledge project. It attempts to implement the KCS method created by the Consortium for Innovation. It is a system for building knowledge bases, like https://support.microsoft.com/. The consortium has a set of roles and permissions.

"Review and either link or flag articles in the problem solving workflow"[1]

The lowest role has the least permissions. They cannot create content, and they cannot edit content, but they can 'flag' content. The moderation notes are those 'flags'. More advanced users, they can create content, and edit some other content, but not all. So more advance users still need the ability to create notes, but not on all content. The most advanced users can edit all content, and no need to create notes.

I could move the permission into the knowledge project, but I think others site builders might want the additional permission.

https://www.drupal.org/project/knowledge →

consortium for innovation
https://www.serviceinnovation.org/

[1] https://library.serviceinnovation.org/KCS/KCS_v6/KCS_v6_Practices_Guide/...

I think that makes more sense - if you can't edit something make a flag/note. If you can edit, just make the change yourself. Kind of an enforced DIY thing for that class of users? I don't think this is a common use case, but can understand it now.

Your changes in PR look good too so when tests pass I can approve (or you can assume that you're good to commit).

I fixed the failing tests, and added additional tests for the new permissions.

Automatically closed - issue fixed for 2 weeks with no activity.