Evolve aria_current, streamline dependencies, widen use cases

Created on 12 August 2023, about 2 years ago

couple improvements could be made:

It is not clear why there is a dependency on jquery.
Instead of having different libraries and dependency logic for anonymous and authenticated users, the module be simplified by utilizing the same data attributes that core uses to add the "is-active". This would remove the need for core dependencies at all.
It is not clear why this module only targets links inside of <nav> when it could add them to any link on the page that has the "is-active" class.

Remove the two libraries and replace it with a single one.
Update the page_attributes_alter.
Copy the code from core's active-links.js and modify it to apply the aria-current="page" attribute instead of "is-active" class.
Create a branch 2.x, tag a 2.0 release, then commit this and create a 2.1-beta1 release for further testing.

📌 Task

Status

Active

Version

1.0

Component

Code

Created by

🇪🇨Ecuador jwilson3

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @jwilson3
@jwilson3 opened merge request.
Status changed to Closed: duplicate 12 months ago1:48pm 18 November 2024
Comment 12 months ago →
🇳🇱Netherlands idebr
This issue was fixed in Drupal Core, see 📌 Add aria-current attribute to navigation items RTBC

Production build 0.71.5 2024