Contrib.social

Evolve aria_current, streamline dependencies, widen use cases

Open on Drupal.org →
Created on 12 August 2023, over 1 year ago

Problem/Motivation

couple improvements could be made:

  1. It is not clear why there is a dependency on jquery.
  2. Instead of having different libraries and dependency logic for anonymous and authenticated users, the module be simplified by utilizing the same data attributes that core uses to add the "is-active". This would remove the need for core dependencies at all.
  3. It is not clear why this module only targets links inside of <nav> when it could add them to any link on the page that has the "is-active" class.

Proposed resolution

  • Remove the two libraries and replace it with a single one.
  • Update the page_attributes_alter.
  • Copy the code from core's active-links.js and modify it to apply the aria-current="page" attribute instead of "is-active" class.
  • Create a branch 2.x, tag a 2.0 release, then commit this and create a 2.1-beta1 release for further testing.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇪🇨Ecuador jwilson3

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024