Module update for Drupal 10

Good afternoon, I added a name to GIT, what should I do next to get the module upgrade to Drupal 10

@Pavel Sivtsov someone needs to create patch or merge request
If I have time I will create it.

Davor can we agree for gratitude?
You can evaluate the work in order to create a patch or merge request, and I will be happy to transfer money to your card or account. I will be very grateful. Thank you in advance.

Davor can we agree for gratitude?
You can evaluate the work in order to create a patch or merge request, and I will be happy to transfer money to your card or account. I will be very grateful. Thank you in advance.

@Pavel Sivtsov Thanks for your offer :D
I will try to create patch asap, hope by wednesday.
No need for money, this is open source project

Okay, let's test it out little bit, and make release later

Trying to follow this progress - anything we could do to help with testing.

@petednz Dev version → should be compatible with drupal 10.

Thank you - appreciate the update

Hello, any update on this?

@kingfisher64 It is commited to dev and needs review

@DavorHorvacki - Thank you for the update :)

I've installed the DEV module on a D10 site. There are a couple of errors that need fixed when running an import.

First:
- I found some weird behaviour with the loading and saving of the log.json file - I think perhas the test to see if it was empty was failing and the file was being loaded and the variable was ending up as a string not an array.

Second:
- There were two errors in the CSV upload form file
($value) must be of type Countable|array, null given in count()
I'm unclear if I've resolved these correctly as when I run and compare the output of field_definitions.json between a working D9 import and Failing D10 one I see the following for example:
Product title doesn't seem to be required on D9 and has no cardinality. On D10 it does with a cardinality of 1. This seems to result in errors regarding the title showing on the post upload screen.

Has anyone else hit something similar and have any advice on resolving?

Very quick fix for first issue load the logfile into a different variable so we don't have it as a string.

      $logfile = file_get_contents($save . '/log.json');
      if (!empty($logfile)) {
	      $log = json_decode($logfile, TRUE);
      }
    }

The second relates to:

TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in count()

At -> https://git.drupalcode.org/project/commerce_smart_importer/-/blob/8.x-1....

and
https://git.drupalcode.org/project/commerce_smart_importer/-/blob/8.x-1....

I think the fix for the first is to change to check if the value isset the second a test for empty will suffice? However following this I see a different set of errors for the same imported CSV. Or should this be expected?

Fix for the above at -> https://www.drupal.org/project/commerce_smart_importer/issues/3454069#co... 🐛 PHP 8.x errors + D10 issues Active couldn't figure out how to push to the above repo, and also looks like it's been merged anyway.