The sidebar in umami appears on top of the content

Created on 11 August 2023, 11 months ago
Updated 16 August 2023, 10 months ago

Problem/Motivation

The existing implementation assumes all themes will have the class .page-wrapper wrapping the existing content, but as it happens in Umami this might not be always like that:

Proposed resolution

Find an alternative and reliable way to leave the needed space for the sidebar.

πŸ› Bug report
Status

Closed: duplicate

Version

1.0

Component

Code

Created by

πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @ckrina
  • πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona
  • πŸ‡¨πŸ‡¦Canada claireristow

    Is it safe to assume the `dialog-off-canvas-main-canvas` will always exist?

  • πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

    Yeah, that's a really good question. In "theory" yes per https://api.drupal.org/api/drupal/core%21modules%21system%21templates%21..., but the reality is that a lot of front-end themes want to have full control of their markup which as can be seen in the off-canvas change record: [#2896596].

    Maybe it would be a good thing to discuss it with @lauriii as the old Front-end framework manager that might have enough context of what happened, @bnjmnm (and the rest of FFM) and other experienced devs to see what can be the best solution.

    I'd personally think yes, we should rely on having the standard off canvas and if somebody wants to customize it they can do it, but this is would definitely be a breaking change and wouldn't let us do it in a minor? Let's discuss it :)

  • πŸ‡ΊπŸ‡ΈUnited States bnjmnm Ann Arbor, MI

    Ideally Umami would leverage off canvas offsets since it's used as a reference for how to fully take advantage of Drupaly things. I think it's also perfectly acceptable to not expect this navigation to work that way on all themes, as long as there are measures taken to ensure it's visible in nearly any theme (even if it's on top of the content instead of pushing it over). CSS layers should hopefully allow this without z-index chaos.

  • Status changed to Closed: duplicate 10 months ago
  • πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

    Closing this to centralize the discussion in πŸ“Œ Admin nav should use Drupal displace API Fixed .

Production build 0.69.0 2024