- Issue created by @ckrina
- π¨π¦Canada claireristow
Is it safe to assume the `dialog-off-canvas-main-canvas` will always exist?
- πͺπΈSpain ckrina Barcelona
Yeah, that's a really good question. In "theory" yes per https://api.drupal.org/api/drupal/core%21modules%21system%21templates%21..., but the reality is that a lot of front-end themes want to have full control of their markup which as can be seen in the off-canvas change record: [#2896596].
Maybe it would be a good thing to discuss it with @lauriii as the old Front-end framework manager that might have enough context of what happened, @bnjmnm (and the rest of FFM) and other experienced devs to see what can be the best solution.
I'd personally think yes, we should rely on having the standard off canvas and if somebody wants to customize it they can do it, but this is would definitely be a breaking change and wouldn't let us do it in a minor? Let's discuss it :)
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Ideally Umami would leverage off canvas offsets since it's used as a reference for how to fully take advantage of Drupaly things. I think it's also perfectly acceptable to not expect this navigation to work that way on all themes, as long as there are measures taken to ensure it's visible in nearly any theme (even if it's on top of the content instead of pushing it over). CSS layers should hopefully allow this without z-index chaos.
- Status changed to Closed: duplicate
over 1 year ago 1:30pm 16 August 2023 - πͺπΈSpain ckrina Barcelona
Closing this to centralize the discussion in π Admin nav should use Drupal displace API Fixed .