- Issue created by @apotek
- πΊπΈUnited States adamzimmermann
Thank you for submitting this. I like the proposed solution+++
- πΊπΈUnited States apotek
> I like the proposed solution+++
@adamzimmerman, I do too :).
so then the settings would look like this:
content_types: 'name of content type': use_datatable: true|false asset_format: TRX|TR1 'another content type': { }
The schema would need this added:
orange_dam.content_type: type: mapping label: 'Content type properties' mapping: use_datatable: type: boolean label: 'Augment with Data Table data' + asset_format: + type: string + label: 'Orange DAM asset format for content type'
Though it would be more elegant if the asset_format type were not a string but an enum type so it could be validated.
This is the easy part. The harder parts:
1. Refactor the parts of the code that were using the`asset_format` key.
2. Write update hook to remove end-users `asset_format` config and move the values into their `content_types` config. - πΊπΈUnited States adamzimmermann
Alternatively, an improvement could be to remove the `asset_formats` key all together and add it to the configuration of the content types, since that is actually what this config key is doing.
I believe this is what you showed in your comment π Schema missing for `asset_formats` key in module settings. Fixed above, and I'm liking it!
This is the easy part. The harder parts:
You are correct.
- @adamzimmermann opened merge request.
- Assigned to adamzimmermann
- Status changed to Needs review
over 1 year ago 4:58pm 8 September 2023 -
adamzimmermann β
committed 26e1951d on 1.x
Issue #3380278 by adamzimmermann, apotek: Schema missing for `...
-
adamzimmermann β
committed 26e1951d on 1.x
- Status changed to Fixed
over 1 year ago 10:44pm 11 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.