Fresh installations emails broken with 1.3.0

Created on 9 August 2023, over 1 year ago
Updated 4 September 2023, about 1 year ago

Problem/Motivation

User emails like "Password forgotten" are empty - no subject and no body with a fresh symfony_mailer 1.3.0 installation.
Also the mail texts form at /admin/config/people/accounts is overridden with the symfony mailer config UI
Configs at /admin/config/system/mailer/override are all disabled

I manually had to import and then disable manually again to get the default core forms at /admin/config/people/accounts and the emails to have subject and content

Now the only problem left is, that the body doesn't have line breaks, but I think that's a different issue.

Steps to reproduce

Just install the module in version 1.3.0

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Anybody
  • 🇩🇪Germany Anybody Porta Westfalica

    Something similar has already been reported here: https://www.drupal.org/project/symfony_mailer/issues/3379690#comment-151... 🐛 Update from 1.2 to 1.3 breaks existing order receipt emails Fixed

    BTW: Composer automatically uses 1.3 (supported) instead of 1.2.2 (recommended)!

  • 🇩🇪Germany Anybody Porta Westfalica

    All existing sites which composer upgraded to 1.3.0 are also broken now and the password forgotten emails for example don't have any value anymore. Setting priority to critical.

    Is it possible to downgrade to 1.2.2 until this is fixed or are there database updates from 1.2.2 to 1.3?

  • 🇩🇪Germany Anybody Porta Westfalica

    Replying to myself in #3: Upgrading from 1.2.1 to 1.3 involves the following database updates:

    symfony_mailer          10008       hook_update_n   10008 - Set initial
                                                          values for override
                                                          configuration.
      symfony_mailer          10009       hook_update_n   10009 - Disable the
                                                          obsolete module
                                                          symfony_mailer_bc.

    And I was in luck to have that 1.2.1 installation, so I could test, if it breaks when updating to 1.3.0 and YES!
    Before the update, the email subject and body were present
    After the update, they are gone!

  • 🇩🇪Germany Anybody Porta Westfalica

    FYI: I don't think 🐛 Disabled overrides should not cause conflicts Fixed but I tried if the patch fixes this issue as side-effect, but it doesn't.

  • 🇩🇪Germany Anybody Porta Westfalica

    I finally downgraded to 1.2.2 (as I use default configuration!) by

    drush pmu symfony_mailer
    composer remove drupal/symfony_mailer
    drush cex -y
    composer require drupal/symfony_mailer:~1.2.2
    drush en symfony_mailer

    Be careful, this will reset all settings to default, but use 1.2.2 which works!

    So as there's a workaround by reinstalling (might fit for most users without special configuration), I'm setting priority to Major.

  • 🇬🇧United Kingdom adamps

    Thanks for the report.

    Your issue summary talks about fresh installations but your comment #3 talks about upgrades, so it's quite confusing. I waited until there were 700 installs of 1.3 before making a stable release, so maybe there is something specific to your site??

  • 🇩🇪Germany Anybody Porta Westfalica

    Hi @AdamPS, sorry for the confusion. We have both. Existing installations, which are working and fresh installations which are broken with 1.3. But what's for sure is, that there's trouble with 1.3 that wasn't there with 1.2.2. So we finally downgraded all projects, existing and fresh to 1.2.2.

    The projects themselves were not fresh, but used Swiftmailer before. Please also see similar reports over here: https://www.drupal.org/project/symfony_mailer/issues/3379690 🐛 Update from 1.2 to 1.3 breaks existing order receipt emails Fixed

    I don't know what should be specific in these projects. symfony_mailer is the only mailing module enabled on all these projects. And the issue appears with the core password forgotten emails.

    Most project are multilingual, but that doesn't seem to be related. The single-language projects are having the same issue with 1.3

  • 🇬🇧United Kingdom adamps

    OK I can reproduce it now, many thanks! It's a strange glitch when first on 1.3 (new site or upgrade) that will go away with some "fiddling". I think this is a workaround:

    • Go to /admin/config/system/mailer/override
    • Clear cache
  • 🇬🇧United Kingdom adamps

    On upgrade it only affects commerce, 🐛 Update from 1.2 to 1.3 breaks existing order receipt emails Fixed

  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    6 pass
  • 🇬🇧United Kingdom adamps

    Please can you test this patch?

  • Status changed to Fixed over 1 year ago
  • 🇬🇧United Kingdom adamps

    This patch also fixes 🐛 Update from 1.2 to 1.3 breaks existing order receipt emails Fixed and was committed on that issue.

  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed about 1 year ago
  • 🇩🇪Germany mspae

    Any ETA on the release containing this fix? Sites doing the Drupal 9 to 10 upgrade are affected by this.

Production build 0.71.5 2024