JavaScript coding standards

As a start, here's a partial patch that just deals with whitespace problems. Let's see what's left after this ...

This patch is the same plus it breaks up the var definitions.

Yeah, that just let eslint identify more errors.
Here's a new patch using let instead of var, naming some functions, and using templates instead of string concatenation in some places.

Re-testing now we have javascript testing in the code base.

The last submitted patch, 4: 3380078-4-js-cs.patch, failed testing. View results →

Moving to 3.0.x. And opening an MR so we can iteratively fix these issues.
New eslint / new JS coding standards are being used on GitLab CI.