TypeError: CommerceGuys\Intl\Formatter\CurrencyFormatter::format(): Argument #1 ($number) must be of type string, null given,

Might need to check this also in the PriceCalculatedFormatter?

I don't really understand how this happens? Technically the price field should be empty? So there should be no need to check if the number isn't empty otherwise that'd mean a price with just a currency code was saved somehow?

Steps to reproduce work. There is no currency code either. The format function doesn't seem to be OK passing a NULL value.

Ofc it's not, i just don't understand why $items isn't simply empty.

@tonytheferg: I just did this on a vanilla install and the order view page doesn't crash... What am I missing?

The orders view, filtered to the draft state

Same on the orders view, works for me...

What formatter are you using for the order total? It doesn't crash with plain, but does with default.

It works with the default formatter, I don't use plain, why would I use plain? :)

why would I use plain?

Why is plain an option then? :)

I mean... I use the default view, which uses the default formatter.
Anyway, there's no issue I can reproduce on my side, so looks like I'll close this... without reproducible steps on a clean install.

Sorry for the runaround. It was this patch:
https://www.drupal.org/project/commerce/issues/3343679 ✨ Convert the order balance computed field to a base field Needs work

Re-opening this, as there actually is an issue in the OrderBalanceFieldItemList class creating a NULL commerce_price instance.

The patch in [33343679-13] includes a fix for this issue.

So why would we reopen this? As this is a consequence of the other patch which is not even committed?