After payment declined, have to submit twice from order info page

Interestingly we just did a live test on a different Moneris account and a real credit card with a declined transaction and it did not show this double submit behavior. I didn't see the test first hand though, I can try to set the test up again if that helps.

vmarchuk → made their first commit to this issue’s fork.

@redsky @rszrama

I created an MR with fixes. The main idea is that we need to generate a new ticket on the Moneris side in case of an error, so for that we need to do $order->unset Data('moneris checkout');. And then a new ticket will be generated in getTicket() method.
Can you test it and let me know the results?

Sounds good @vmarchuk, I'm testing this now.

Thanks!

Thanks for this MR!

I tested this out and it did stop the need to press submit twice after having a declined transaction but only for the "Moneris Checkout order number strategy" named "Use the order ID with timestamp appended". (See https://www.drupal.org/project/commerce_moneris_checkout/issues/3367095 📌 Should the order_no field be the Commerce Order No? Fixed )

For the "Moneris Checkout order number strategy" named "Generate the order number early and use it instead of the ID" it fails. Without this MR, each submissions generates a new order_no which is consistent with the help text message "Note: generating order numbers will likely result in out of order or missing order numbers based on if / when the orders are placed." Those wasted numbers were missing from Drupal but they did show up as declined transactions in Moneris.

We'd love it if the double pressing submit bug could be solved and still generate new order_no's with each Moneris call.

Thanks,
Chris

@redsky @rszrama

I added a fix to MR and changed the strategy a bit.
Can you test it and let me know the results?

Great thanks @vmarchuk, I'm going to test it now.

This is working in my initial tests - just waiting to here back from our client.

I can confirm this MR worked. I accepted the Merge Request.

Creating release 1.0.1, closing.