- Issue created by @Haris Khan Jadoon
- Status changed to Closed: won't fix
over 1 year ago 2:20pm 8 August 2023 - 🇳🇴Norway gisle Norway
Hi, I am a site moderator on Drupal.org and I would like to comment on this issue:
You created this issue, and assigned yourself to it, claiming to update the Drupal 10 version. For starters, a lot more work than adding a line with
core_version_requirement
key claiming to be Drupal 10 compatible is usually required.From the metadata, I see that this patch is supposed to be for the 2.0.0 version, but the file patched "
ckeditor_readmore.info
" does not exist in that version. You've obviously not tested this patch before uploading it.Also, the
core_version_requirement
added, i.e.:core_version_requirement = ^8 || ^9 || ^10
is illogical. It claims compatibility with all versions of Drupal 8, but prior to version Drupal 8.8,
core_version_requirement
did no exits.I kindly request that you do not create any more of these issues to only add a
core_version_requirement
key, as they seem to be repeated posting of trash content. Please note that such activity may lead to you being blocked from posting on Srupal.org. See Moderating users → for reference. - 🇮🇹Italy apaderno Brescia, 🇮🇹
diff --git a/ckeditor_readmore.info b/ckeditor_readmore.info index 5e5637c..11117f6 100644 --- a/ckeditor_readmore.info +++ b/ckeditor_readmore.info @@ -1,6 +1,6 @@ name = CKEditor Read more description = Adds a CKEditor Read more plugin. -core = 7.x +core_version_requirement = ^8 || ^9 || ^10 package = user-interface dependencies[] = ckeditor
Haris Khan Jadoon, the 2.x branch does not have any ckeditor_readmore.info file.
You are changing the Drupal 7 files, when a Drupal 7 module cannot be made compatible with Drupal 10. A Drupal 7 module runs only on Drupal 7.