- Issue created by @bedstvie
- First commit to issue fork.
- π¦π²Armenia murz Yerevan, Armenia
Thank you for the patch, I moved it to a separate branch, reviewed and made some changes:
- Together with enabling translation, it also adds revisions to the entities. I don't think that this is a good idea to add revisions by default because revisions create additional tables and data in the database, which slows down the performance and increase the database size.
But Localities entities are usually not edited manually, but imported from OSM, so there is no need to store all revisions.
If some custom modules really need revisions for OSM entity types, they can alter the definition and add revision properties to them on their own.
Also, I moved published and name field definitions to the base class, to simplify the code.
The patch needs review and also will be good to test it on some sites before merging. My website that uses this module, is already dead, so I have no environment to widely test this patch.
@Bedstvie, could you please review and test, if you can?
- Merge request !2Issue #3379805 by Bedstvie: Make OSM Entities Translatable β (Open) created by murz
- Status changed to Needs review
9 months ago 10:50am 17 February 2024