Make OSM Entities Translatable

Created on 7 August 2023, 11 months ago
Updated 17 February 2024, 4 months ago

Problem/Motivation

Patch adds the ability to translate osm entities.

πŸ“Œ Task
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine Bedstvie

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Bedstvie
  • First commit to issue fork.
  • πŸ‡¦πŸ‡²Armenia Murz Yerevan, Armenia

    Thank you for the patch, I moved it to a separate branch, reviewed and made some changes:

    - Together with enabling translation, it also adds revisions to the entities. I don't think that this is a good idea to add revisions by default because revisions create additional tables and data in the database, which slows down the performance and increase the database size.

    But Localities entities are usually not edited manually, but imported from OSM, so there is no need to store all revisions.

    If some custom modules really need revisions for OSM entity types, they can alter the definition and add revision properties to them on their own.

    Also, I moved published and name field definitions to the base class, to simplify the code.

    The patch needs review and also will be good to test it on some sites before merging. My website that uses this module, is already dead, so I have no environment to widely test this patch.

    @Bedstvie, could you please review and test, if you can?

  • Status changed to Needs review 4 months ago
Production build 0.69.0 2024