Contrib.social

Page template footer flag checking for class name instead of value

Open on Drupal.org →
Created on 7 August 2023, over 1 year ago
Updated 20 September 2023, over 1 year ago

Problem/Motivation

In /uswds_base/preprocess/layout/page.preprocess.inc there are template helper flags for checking which USWDS footer style is being used. The flags however are checking that the theme setting values match the CSS class instead of the actual theme setting value. This makes the flags have values that are always false.

$variables['footer_slim'] = ('usa-footer--slim' == $variables['footer_style']);
$variables['footer_medium'] = ('usa-footer--medium' == $variables['footer_style']);
$variables['footer_big'] = ('usa-footer-big' == $variables['footer_style']);

Instead the flags need to check theme setting value: slim, medium, big.

Proposed resolution

Check for the actual theme setting value instead of the CSS class.

Remaining tasks

  1. Confirm issue
  2. Provide patch

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Fixed

Version

3.4

Component

Code

Created by

🇺🇸United States pcate

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024