Skip google link for unpublished events

Created on 6 August 2023, over 1 year ago
Updated 24 August 2023, about 1 year ago

Problem/Motivation

Imported calendar events that are not public have a link that shows an error :

https://calendar.google.com/calendar/u/0/event?eid=N3N0cWQ0N2w1YmpyYjZmd...

When the event is public and the user is logged in, it shows the event in their google calendar account. This does not work for private events.

Steps to reproduce

Import non public events, check the Google Link field.

Proposed resolution

Skip importing the link if the event is not visible.

Remaining tasks

Discuss other options, like if the user wants to see a private link to their own google event. I'm not sure if that is possible.

User interface changes

The google link field would not appear for private events.

API changes

See \Drupal\google_calendar\GoogleCalendarImportEvents and \Google\Service\Calendar\Event for API options.

Data model changes

Google link field will be empty if private.

πŸ› Bug report
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mortona2k
  • @mortona2k opened merge request.
  • πŸ‡¬πŸ‡§United Kingdom rivimey
  • πŸ‡¬πŸ‡§United Kingdom rivimey

    I'm not sure of the benefit of removing the link from the import, and I don't know conclusively if a private link is indeed useless, or just requires the right conditions. Consequently I am not minded to apply the patch. Can you explain the reasoning further?

  • πŸ‡ΊπŸ‡ΈUnited States mortona2k Seattle

    For me, the private event link went to an error page. Are you able to do anything useful with it? I suspect we are better off handling an ID for the event.

    I could imagine this showing as a link to add the calendar event, if we could modify it for that.

Production build 0.71.5 2024