Add test for news schema.org metadata when there is no image

Created on 4 August 2023, 11 months ago

Updated 10 August 2023, 11 months ago

Problem/Motivation

The schema object was rendering an image object whether the URL was populated or not

Steps to reproduce

1. Map image url to a field image with an image style and absolute URL.
2. Hardcode width and height because we used an image style defining width and height, and representativeOfPage because we know which value we want there.
3. Don't have an image in our content.

Proposed resolution

Given that the resolution was already provided on Issue https://www.drupal.org/project/schema_metatag/issues/3339740 🐛 If SchemaArticleImage url is empty, we shouldn't render the object at all Fixed , this one will provide testing coverage

Remaining tasks

Provide a test to validate that the Image Object isn't being rendered when the image isn't provided

User interface changes

API changes

Data model changes

📌 Task

Status

RTBC

Version

3.0

Component

Code

Created by

edmoreta

Live updates comments and jobs are added and updated live.

testing
Used for Documentation issues related to testing and test development

Comments & Activities

Issue created by @edmoreta
Comment 11 months ago →
edmoreta
I'm not sure if we still need to refactor the SchemaMetatagTagsTestBase.php class
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 11 months ago
64 pass
@edmoreta opened merge request.
Status changed to Needs review 11 months ago11:30pm 9 August 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
last update 11 months ago
63 pass
Comment 11 months ago →
edmoreta
#3 has an approach that refactors the Base class. Let me know your thoughts about it
Status changed to RTBC 11 months ago10:09am 10 August 2023
Comment 11 months ago →
🇺🇸United States DamienMcKenna NH, USA
The merge request looks good, thank you!

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024