- Issue created by @adam_b
- ๐ฎ๐ณIndia Indranil Roy kolkata
Indranil Roy โ made their first commit to this issueโs fork.
- Assigned to bobi-mel
- Assigned to rakesh.regar
- ๐ฎ๐ณIndia rakesh.regar Rajasthan, India
I'm working on this.
I'll add a confirmation popup where the default time will be there and if you wish to change the time you can generate link.
- ๐ฎ๐ณIndia rakesh.regar Rajasthan, India
I tried to add feature to set different validation time for each user and it seems it will take alot time as we need to override the default reset password functions
so I'll add a link to a form that will allow to customize valid time for all users.
- @rakeshregar opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:06pm 17 October 2023 - ๐ฎ๐ณIndia rakesh.regar Rajasthan, India
Feature is developed and MR raised, please review. moving to Needs review.
- ๐บ๐ธUnited States MegaKeegMan
Looking at this, I see a few things that are a bit out of place. The configuration is under the people admin menu and pages rather than under configuration -> people. There is also a typo in the link /admin/people/configutre-password-timeout
I don't mind making these changes if a maintainer gives a thumbs up on tweak to the menu and routes. I am looking to get this issue completed in combination with https://www.drupal.org/project/one_time_login_link_admin/issues/3495380 โจ Configurable email Active and it doesn't matter to me which one comes in first. Happy to fix any merge conflicts either way.
- ๐บ๐ธUnited States MegaKeegMan
Your changes do appear to function though.
Looking back at earlier comments, I understand why this configuration was placed in the people admin area, given that it looks like the earlier ambition was to be able to change the valid time per user.
- ๐บ๐ธUnited States MegaKeegMan
The new branch and MR is simply a fresh rebase onto 1.0.x
My UX questions / concerns still stand, but if you all are happy with the way it is done, I don't want my opinions on this to get in the way of getting this feature in, especially since the code is functioning and the feature does work as intended.