AcquiaSearchSolrApi:getCores calls lock_acquire for entire request

$now = REQUEST_TIME; while (!lock_acquire('acquia_search_get_search_indexes')) { // Throw an exception after X amount of seconds. if (($now + self::REQUEST_TIMEOUT) < REQUEST_TIME) { throw new \Exception("Couldn't acquire lock for 'acquia_search_get_search_indexes' in less than " . self::REQUEST_TIMEOUT . " seconds."); } }

Comments & Activities

Issue created by @jdleonard
Comment over 1 year ago →
🇺🇸United States jdleonard Austin, TX, USA
Cross-referencing Acquia support case #00975363
Status changed to Needs review over 1 year ago6:17pm 7 August 2023
Open on Drupal.org →
Core: 7.x + Environment: PHP 7.4 & MySQL 5.6
last update over 1 year ago
Waiting for branch to pass
Comment over 1 year ago →
🇺🇸United States japerry KVUO
Pushed internally for review, however you can test the fix with the attached patch as well.
Status changed to Needs work about 1 year ago6:50pm 4 October 2023
Comment about 1 year ago →
🇺🇸United States jdleonard Austin, TX, USA
This patch did not address the issue for us.

$now = REQUEST_TIME; ... if (($now + self::REQUEST_TIMEOUT) < REQUEST_TIME)
is equivalent to:
if (REQUEST_TIME + self::REQUEST_TIMEOUT < REQUEST_TIME)
which will always be false.

Perhaps also part of the problem is the use of REQUEST_TIME instead of time(). In the event that this code is reached from a long-running process (i.e. where the request started more than 60 seconds ago), the problem will be compounded.

Our use case involves operations performed by long-running Drush command executions though I don't believe that our niche use case is the only one that would be affected.
Comment 8 months ago →
🇺🇸United States calebtr
It looks like this patch is included in 7.x-4.6. I don't see the conditional logic referenced in #4 included in AcquiaSearchSolrApi::getCores().