- Issue created by @ckrina
- ๐ช๐ธSpain ckrina Barcelona
Moving to minor since it won't be necessary for testing purposes.
- Assigned to claireristow
- @claireristow opened merge request.
- Status changed to Needs review
over 1 year ago 6:36pm 16 August 2023 - ๐จ๐ฆCanada claireristow
Hey @ckrina, do you mind doing a quick review of my work? I'm wondering if you're ok with the mask-image approach I took for hover color changes or if you'd prefer to have multiple color versions of the icons, or if there's another option entirely!
- Status changed to Needs work
about 1 year ago 1:15pm 24 August 2023 - ๐ช๐ธSpain ckrina Barcelona
@claireristow nice work!
About the mas itself, I personally think itโs a really good modern strategy to avoid what core is currently doing by storing the same icon in several colors. This is assuming all icons will be monochromatich, which Iโd say itโs a safe assumption. It is also good because itโll let us play with accent colors in the future letting us customize the admin UI colors. So unless anybody else has more insights I donโt oversee any problem with this,
The only thing I'd change here is that I would use a BEM pattern to name icons, and use each icon name as a modifier. From
navigation-icon-media
Iโd convert it tonavigation-linkโmedia
.You can see an example in action-link.pcss.css.
- ๐บ๐ธUnited States mherchel Gainesville, FL, US
ckrina โ credited mherchel โ .
- ๐ช๐ธSpain ckrina Barcelona
Make sure if the SVGs are inlined into the CSS, you abstract them to a CSS variable (so the long SVG doesn't get output twice). Also keep in mind you'll pretty much always want to use them in pseudo-classes because the mask covers up everything else.
This is @mherchel feedback in Slack :)
- ๐จ๐ฆCanada claireristow
Thanks for the feedback @ckrina and @mherchel, I'll work on those changes!
-
claireristow โ
committed d7d5a2c1 on 1.x
Issue #3379057: Move all the icons to CSS backgrounds
-
claireristow โ
committed d7d5a2c1 on 1.x
- Issue was unassigned.
- Status changed to Fixed
about 1 year ago 2:54pm 28 August 2023 - ๐จ๐ฆCanada claireristow
Merged updates to BEM-style classes and setup CSS variables for icons!
Automatically closed - issue fixed for 2 weeks with no activity.