Non-namespaced method causes issues with PHPStan

Created on 3 August 2023, over 1 year ago

Problem/Motivation

If I have menu_block_title and responsive_menu installed, then PHPStan fails because the same non-namespaced function is defined in both modules.

Steps to reproduce

$ vendor/bin/phpstan analyse modules/contrib/menu_block_title modules/contrib/responsive_menu
...
Fatal error: Cannot redeclare _create_node() (previously declared in modules/contrib/menu_block_title/tests/modules/responsive_menu_test/menu_block_title_test.install:127) in modules/contrib/responsive_menu/tests/modules/responsive_menu_test/responsive_menu_test.install on line 129

Proposed resolution

Add the module namespace to the function name.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom longwave UK

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @longwave
Status changed to Needs review over 1 year ago8:40am 3 August 2023
Open in Jenkins → Open on Drupal.org →
Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
last update over 1 year ago
8 pass
Comment over 1 year ago →
🇬🇧United Kingdom longwave UK
Status changed to Closed: duplicate 11 days ago9:01pm 9 April 2025
Comment 11 days ago →
🇺🇸United States smustgrave
Thanks! I'm going to address in https://www.drupal.org/project/menu_block_title/issues/3518304 📌 Update gitlab file Active but saving credit for the patch

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024