Nominatim does not support the geocode request URL with trailing slash anymore

I opened a pull request. Here's also a patch.

I forgot the reverse geocoding option, that also needed a change.

#4 didn't work for me on version 8.x-3.x so here's patch for that.

+++ b/modules/geolocation_leaflet/src/Plugin/geolocation/Geocoder/Nominatim.php
@@ -39,7 +39,7 @@ class Nominatim extends GeocoderBase implements GeocoderInterface {
     $request_url_base = $this->getRequestUrlBase();
-    $url = Url::fromUri($request_url_base . '/search/' . $address, [
+    $url = Url::fromUri($request_url_base . '/search?q=' . $address, [
       'query' => [
         'email' => $this->getRequestEmail(),
         'limit' => 1,
 

A cleaner approach might be to include the address within the query.

    $url = Url::fromUri($request_url_base . '/search', [
      'query' => [
        'q' => $address,
        'email' => $this->getRequestEmail(),
        'limit' => 1,
        'format' => 'json',
        'connect_timeout' => 5,
      ],
    ]);

- updated geocoding definition as above
- updated reverse geocoding
- split base URLs for both
- added test
- fixed minor issue in standard country definition

ChristianAdamski → closed merge request !27

Tests not yet working. Merged stuff manually, MR closed.

Thanks everyone!

Automatically closed - issue fixed for 2 weeks with no activity.