- Issue created by @jonathanshaw
- Merge request !348Issue #3378771: Don't require source entity type to be specified in querystring if it is configured β (Open) created by jonathanshaw
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 492 pass, 72 fail - Status changed to Needs review
over 1 year ago 2:19pm 2 August 2023 - last update
over 1 year ago 534 pass - π¬π§United Kingdom jonathanshaw Stroud, UK
The test fails were a bit weird, seems like the querystring source plugin is running when webform submissions are being viewed, but in those cases there is no upcast webform route parameter to get the setting from.
- Status changed to Postponed: needs info
over 1 year ago 3:13pm 3 August 2023 - πΊπΈUnited States jrockowitz Brooklyn, NY
We need to document the steps required to reproduce this issue.
- Status changed to Needs work
9 months ago 3:11pm 7 April 2024 - Status changed to Needs review
9 months ago 8:38pm 8 April 2024 - last update
9 months ago 495 pass, 68 fail - πΊπΈUnited States jrockowitz Brooklyn, NY
I tweaked the MR to be very simple enhancement.
- last update
9 months ago 495 pass, 68 fail - last update
9 months ago 536 pass - πΊπΈUnited States jrockowitz Brooklyn, NY
I reverted my two commits. I am baffled why all those tests broken.
Below is the code snippet I was trying to use
// Get and check source entity type. $source_entity_type = $this->request->query->get('source_entity_type'); // If the source entity type is not defined, attempt to get the // source entity type from the webform's settings. if (!$source_entity_type && $webform->getSetting('form_prepopulate_source_entity')) { $source_entity_type = $webform->getSetting('form_prepopulate_source_entity_type'); } if (!$source_entity_type || !$this->entityTypeManager->hasDefinition($source_entity_type)) { return NULL; }
- π¬π§United Kingdom jonathanshaw Stroud, UK
See #5. In some circumstances the webform parameter is not upcast by the route.
- πΊπΈUnited States jrockowitz Brooklyn, NY
I am open to merging this AS-IS